Skip to content

Fix to use accurate message for validating a string argument is not null and not an empty string #26668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daxian-dbw wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −14
Open

Fix to use accurate message for validating a string argument is not null and not an empty string #26668

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions src/System.Management.Automation/engine/CommandCompletion/CompletionResult.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,26 +168,15 @@ internal static CompletionResult Null
/// <param name="toolTip">The text for the tooltip with details to be displayed about the object.</param>
public CompletionResult(string completionText, string listItemText, CompletionResultType resultType, string toolTip)
{
if (string.IsNullOrEmpty(completionText))
{
throw PSTraceSource.NewArgumentNullException(nameof(completionText));
}

if (string.IsNullOrEmpty(listItemText))
{
throw PSTraceSource.NewArgumentNullException(nameof(listItemText));
}
ArgumentException.ThrowIfNullOrEmpty(completionText);
ArgumentException.ThrowIfNullOrEmpty(listItemText);
ArgumentException.ThrowIfNullOrEmpty(toolTip);

if (resultType < CompletionResultType.Text || resultType > CompletionResultType.DynamicKeyword)
{
throw PSTraceSource.NewArgumentOutOfRangeException(nameof(resultType), resultType);
}

if (string.IsNullOrEmpty(toolTip))
{
throw PSTraceSource.NewArgumentNullException(nameof(toolTip));
}

_completionText = completionText;
_listItemText = listItemText;
_toolTip = toolTip;
Expand Down
Loading