Skip to content

Add ValidateNotNullOrEmpty attribute to the -Property of Format-Table/List/Custom #26552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daxian-dbw wants to merge 2 commits into
base: master
Choose a base branch
from
+16 −0
Open

Add ValidateNotNullOrEmpty attribute to the -Property of Format-Table/List/Custom #26552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fcbfd8
Add `ValidateNotNullOrEmpty` attribte to the `-Property` of `Format-T…
daxian-dbw Dec 1, 2025
9babe7e
Add test
daxian-dbw Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...werShell.Commands.Utility/commands/utility/FormatAndOutput/format-object/Format-Object.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ public FormatCustomCommand()
/// will be determined using property sets, etc.
/// </summary>
[Parameter(Position = 0)]
[ValidateNotNullOrEmpty]
public object[] Property
{
get { return _props; }
Expand Down
1 change: 1 addition & 0 deletions src/System.Management.Automation/FormatAndOutput/common/BaseFormattingCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,6 +727,7 @@ public class OuterFormatTableAndListBase : OuterFormatShapeCommandBase
/// will be determined using property sets, etc.
/// </summary>
[Parameter(Position = 0)]
[ValidateNotNullOrEmpty]
public object[] Property { get; set; }

#endregion
Expand Down
14 changes: 14 additions & 0 deletions test/powershell/engine/Formatting/BugFix.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,17 @@ Describe "Hidden properties should not be returned by the 'FirstOrDefault' primi
$outstring.Trim() | Should -BeExactly "Param$([System.Environment]::NewLine)-----$([System.Environment]::NewLine)Foo"
}
}

Describe "'Format-Table/List/Custom -Property' should not throw NullRef exception" -Tag CI {

It "'<Command> -Property' requires value to be not null and not empty" -TestCases @(
@{ Command = "Format-Table"; NameInErrorId = "FormatTableCommand" }
@{ Command = "Format-List"; NameInErrorId = "FormatListCommand" }
@{ Command = "Format-Custom"; NameInErrorId = "FormatCustomCommand" }
) {
param($Command, $NameInErrorId)

{ Get-Process -Id $PID | & $Command -Property @() } | Should -Throw -ErrorId "ParameterArgumentValidationError,Microsoft.PowerShell.Commands.$NameInErrorId"
{ Get-Process -Id $PID | & $Command -Property $null } | Should -Throw -ErrorId "ParameterArgumentValidationError,Microsoft.PowerShell.Commands.$NameInErrorId"
}
}
Loading