Remove redundant CharSet from StructLayout in structs without string-related fields
#26005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99b31a3 to
f445d43
Compare
f445d43 to
4cc76a8
Compare
CharSet from StructLayout attributes on non-string structsCharSet from StructLayout in structs without string-related fields
iSazonov
approved these changes
Oct 16, 2025
Remove explicit `CharSet` values from `[StructLayout]` attributes applied to structs that do not contain `char`, `string`, or `StringBuilder` fields.
4cc76a8 to
7a6b900
Compare
Contributor
Author
|
Rebased after fcb0e5c |
iSazonov
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove explicit
CharSetvalues from[StructLayout]attributes applied to structs that do not containchar,stringorStringBuilderfields.The
CharSetfield in[StructLayout]influences marshalling behavior only when a struct includeschar,stringorStringBuildermembers. For structs that contain only value types or blittable types, specifyingCharSetis redundant and has no effect on layout or marshaling.