Skip to content

Conversation

@AndSonder
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Description

Fix parameter passing for comm_buffer_size_MB and release_gradients

@paddle-bot
Copy link

paddle-bot bot commented Nov 22, 2024

Thanks for your contribution!

@codecov
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 53.08%. Comparing base (9ee691a) to head (dd18703).
Report is 226 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/training_args.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9481      +/-   ##
===========================================
- Coverage    53.40%   53.08%   -0.33%     
===========================================
  Files          685      685              
  Lines       110166   108906    -1260     
===========================================
- Hits         58837    57812    -1025     
+ Misses       51329    51094     -235     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 1ba3bef into PaddlePaddle:develop Nov 22, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants