Skip to content

Conversation

@DrownFish19
Copy link
Collaborator

PR types

Function optimization

PR changes

Others

Description

Skip zero loss in Qwen2.

This function is applyed in llama #8389.

@paddle-bot
Copy link

paddle-bot bot commented Nov 18, 2024

Thanks for your contribution!

@codecov
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 52.81%. Comparing base (79bba4f) to head (a41d712).
Report is 226 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/transformers/qwen2/modeling.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9447      +/-   ##
===========================================
+ Coverage    52.70%   52.81%   +0.10%     
===========================================
  Files          677      677              
  Lines       109391   107944    -1447     
===========================================
- Hits         57658    57008     -650     
+ Misses       51733    50936     -797     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 554941f into PaddlePaddle:develop Nov 20, 2024
9 of 12 checks passed
@DrownFish19 DrownFish19 deleted the dev_20241118_qwen2_modeling_zero_mean branch November 20, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants