[Refactor] SFTTrainer SFTConfig #9318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9318 +/- ##
===========================================
- Coverage 53.09% 53.07% -0.02%
===========================================
Files 699 699
Lines 110471 110348 -123
===========================================
- Hits 58651 58569 -82
+ Misses 51820 51779 -41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
wawltor
reviewed
Nov 25, 2024
| return fn | ||
|
|
||
| return docstring_decorator | ||
| from paddlenlp.trainer.utils.doc import add_start_docstrings |
| @@ -0,0 +1,102 @@ | |||
| # Copyright (c) 2024 PaddlePaddle Authors. All Rights Reserved. | |||
Contributor
There was a problem hiding this comment.
这里放到paddlenlp library我想到的一个问题是，如果用户想新增相关的参数就必须要改动library，因此最近developllm工具必须适配最新的library，看起来会导致一些兼容问题。
Contributor
Author
There was a problem hiding this comment.
可以引导 用户使用
- 正式版lib + 正式版 llm
- dev lib + dev llm
不要混用。
实际是上，大部分更新的参数，用户并不会使用到。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Others