🩹 [Patch]: Remove reliance on GitHub
#51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onsistency in Publish-PSModule action
There was a problem hiding this comment.
Pull Request Overview
This PR replaces generic LogGroup calls with Set-GitHubLogGroup, streamlines the GitHub Action step to invoke PowerShell directly, and refines the Publish-PSModule script’s metadata by removing GitHub Pages references.
- Replaced all
LogGroupinvocations inmain.ps1andPublish-PSModule.ps1withSet-GitHubLogGroup - Simplified
action.ymlto usepwshand direct script invocation instead ofPSModule/GitHub-Script - Updated module metadata comments to focus on PowerShell Gallery publishing
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/main.ps1 | Swapped LogGroup for Set-GitHubLogGroup around input/loading |
| scripts/helpers/Publish-PSModule.ps1 | Adjusted .SYNOPSIS/.DESCRIPTION and replaced logging calls |
| action.yml | Removed uses: step, added shell: pwsh, working-directory, and run: |
Comments suppressed due to low confidence (2)
action.yml:88
- After replacing
uses:withrun:, ensure that all previously mapped inputs (Debug, Prerelease, Verbose, Version, VersionPrefix, WhatIf, etc.) are still provided via environment variables, since thewith:block was removed.
env:
scripts/helpers/Publish-PSModule.ps1:99
- [nitpick] Log group titles use inconsistent capitalization ('details' vs 'Labels'). Consider standardizing on a single casing style (e.g., title case) for all headings.
Set-GitHubLogGroup 'Pull request - details' {
…gging in Publish-PSModule script
… and clean up action.yml inputs
…on to clarify GitHub Release creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces several updates to streamline the PowerShell module publishing process and enhance logging functionality. Key changes include replacing
LogGroupwithSet-GitHubLogGroupfor improved GitHub-specific logging, simplifying theaction.ymlconfiguration, and refining thePublish-PSModulescript to focus solely on publishing to the PowerShell Gallery.Updates to
action.ymlConfiguration:GitHub-Scriptto running the script directly withpwshshell, enabling better control over the execution environment. ([[1]](https://github.com/PSModule/Publish-PSModule/pull/51/files#diff-1243c5424efaaa19bd8e813c5e6f6da46316e63761421b3e5f5c8ced9a36e6b6L86-R87),[[2]](https://github.com/PSModule/Publish-PSModule/pull/51/files#diff-1243c5424efaaa19bd8e813c5e6f6da46316e63761421b3e5f5c8ced9a36e6b6L102-R103))Enhancements to Logging:
LogGroupwithSet-GitHubLogGroupinscripts/helpers/Publish-PSModule.ps1andscripts/main.ps1for improved GitHub-specific structured logging. ([[1]](https://github.com/PSModule/Publish-PSModule/pull/51/files#diff-780715ac24c6bbe21b54f3d268778136b79f21a62275bbd494dfa857b4ba40d9L36-R36),[[2]](https://github.com/PSModule/Publish-PSModule/pull/51/files#diff-780715ac24c6bbe21b54f3d268778136b79f21a62275bbd494dfa857b4ba40d9L62-R73),[[3]](https://github.com/PSModule/Publish-PSModule/pull/51/files#diff-dc2e5a659836b1b73abb03421c567f5018c2755677c4a0aa764cb26117b68011L21-R28), and others)Refinements to
Publish-PSModuleScript:.DESCRIPTIONand.SYNOPSISsections to remove references to GitHub Pages, focusing exclusively on publishing modules to the PowerShell Gallery. ([scripts/helpers/Publish-PSModule.ps1L4-R7](https://github.com/PSModule/Publish-PSModule/pull/51/files#diff-780715ac24c6bbe21b54f3d268778136b79f21a62275bbd494dfa857b4ba40d9L4-R7))[scripts/helpers/Publish-PSModule.ps1L4-R7](https://github.com/PSModule/Publish-PSModule/pull/51/files#diff-780715ac24c6bbe21b54f3d268778136b79f21a62275bbd494dfa857b4ba40d9L4-R7))Type of change
Checklist