Skip to content

Conversation

@MariusStorhaug
Copy link
Member

@MariusStorhaug MariusStorhaug commented Jun 27, 2025

Description

This pull request updates GitHub Actions workflows to improve functionality and maintainability. The changes include removing a redundant comment from the Action-Test workflow and modifying the TestWorkflow to specify the repository owner explicitly in multiple job configurations.

Updates to GitHub Actions workflows:

  • .github/workflows/Action-Test.yml: Removed a redundant comment related to skipping a Checkov rule for tag references.
  • .github/workflows/TestWorkflow.yml: Updated the Get-GitHubRepository command in three job configurations (ActionTestWithUSERFGPAT, ActionTestWithORGFGPAT, and ActionTestWithGitHubAppEnt) to include the -Owner PSModule parameter for specifying the repository owner explicitly. [1] [2] [3]

Type of change

  • 📖 [Docs]
  • 🪲 [Fix]
  • 🩹 [Patch]
  • ⚠️ [Security fix]
  • 🚀 [Feature]
  • 🌟 [Breaking change]

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Copilot AI review requested due to automatic review settings June 27, 2025 12:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR primarily fixes issues within the GitHub workflow files. It updates calls to Get-GitHubRepository by adding the '-Owner PSModule' parameter for improved specificity and removes a checkov skip annotation from the Action-Test workflow.

  • Updated Get-GitHubRepository invocations in TestWorkflow.yml to include a hard-coded owner parameter.
  • Removed the checkov skip comment from Action-Test.yml.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/TestWorkflow.yml Changed multiple LogGroup sections to include "-Owner PSModule" in the Get-GitHubRepository call.
.github/workflows/Action-Test.yml Removed the checkov skip annotation to possibly enforce stricter scanning in the workflow.
Comments suppressed due to low confidence (1)

.github/workflows/Action-Test.yml:1

  • Removing the checkov skip annotation may trigger additional warnings during automated scans; please verify that this removal aligns with the intended quality and security policies.
name: Action-Test

@MariusStorhaug MariusStorhaug changed the title Fix 🩹 [Patch]: Add output for GitHubRepos from PSModule Jun 27, 2025
@MariusStorhaug MariusStorhaug self-assigned this Jun 27, 2025
@MariusStorhaug MariusStorhaug merged commit 19dcf65 into main Jun 27, 2025
110 checks passed
@MariusStorhaug MariusStorhaug deleted the fix branch June 27, 2025 13:43
@MariusStorhaug MariusStorhaug restored the fix branch June 27, 2025 13:46
@MariusStorhaug MariusStorhaug deleted the fix branch June 27, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants