Skip to content

Conversation

@vercellone
Copy link
Contributor

Description

Invoke-GitHubRestMethod won't work if it is trying to call Join-UriAndQueryParameters instead of Join-WebUriAndQueryParameters. Although, that function has not been published to PSGallery yet. It only exists in https://github.com/PSModule/Web/pull/5 which is evidently on hold due to the encoding of spaces in query strings.

Type of change

  • 📖 [Docs]
  • 🪲 [Fix]
  • 🩹 [Patch]
  • ⚠️ [Security fix]
  • 🚀 [Feature]
  • 🌟 [Breaking change]

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@vercellone vercellone requested a review from a team as a code owner February 6, 2025 03:07
Copy link
Member

@MariusStorhaug MariusStorhaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MariusStorhaug MariusStorhaug merged commit 5f21672 into PSModule:vercellone/RestMethod Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants