fix: do not clear androidView._cachedDrawable #8475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as abuse.
This comment was marked as abuse.
Contributor
Author
|
@NathanaelA that’s what I’m trying to solve and seems that this fixes the mapbox issue and I want to see whether it breaks anything else. |
b733907 to
522ab8d
Compare
vmutafov
approved these changes
Apr 1, 2020
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
It seems that keeping the cache solves the problem with
newDrawable(android.content.res.Resources) on null object. However, it is not clear why we were clearing it from the cache.Fixes #7954, #7867.