feat(core): Ensure concurrency when firing events #10946
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Right now, core has concurrency problems when it comes to firing events.
To mitigate this for regular events, listener callbacks are fired in the reverse order thanks to #854.
Also, in the case of gesture listeners, some callbacks aren't fired if
removeEventListeneris called inside one of them while firing the event.What is the new behavior?
Keep a copy of listener array when there's more than 1 of them.
This will ensure concurrency while firing events and event callbacks will fire in the correct order.
BREAKING CHANGES:
If by any chance there are users who rely in the faulty execution order, this change will affect them.