Skip to content

chore: Delete generated aar files #10372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: Delete generated aar files #10372

wants to merge 2 commits into from

Conversation

@farfromrefug
Copy link
Collaborator

@farfromrefug farfromrefug commented Sep 4, 2023 •
edited by NathanWalker
Loading

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

@cla-bot cla-bot bot added the cla: yes label Sep 4, 2023
NathanWalker
NathanWalker requested changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@NathanWalker NathanWalker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears widgets-release.aar needs to stay since ui-mobile-base is not built with npm release, prebuilt to save time, but core.aar may can be removed.

@CatchABus
Copy link
Contributor

CatchABus commented Sep 4, 2023 •
edited
Loading

@farfromrefug It seems that core.aar was not purposely generated. I think it might be a result of a build in NativeScript/apps? Not sure.
We could remove core.aar and add a gitignore rule for it to make sure nobody commits it again in the future.

@farfromrefug
Copy link
Collaborator Author

farfromrefug commented Sep 4, 2023

@NathanWalker it should be best to rebuild it on each npm release to ensure we are up to date with sources. I do that in my fork without any issue

@farfromrefug
Copy link
Collaborator Author

farfromrefug commented Sep 4, 2023

@CatchABus indeed I will add a gitignore

@NathanWalker NathanWalker added this to the 9.0 milestone Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NathanWalker NathanWalker NathanWalker requested changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

9.0

Development

Successfully merging this pull request may close these issues.

4 participants

@farfromrefug @CatchABus @NathanWalker