Add build statistics to Log Manifest Entry, exact build duration #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @AvdLee I'm likely to pull this into my fork which repairs the function/typecheck timings, since I think this would be quite useful for us |
aleksandergrzyb
previously approved these changes
Mar 20, 2025
Collaborator
Author
|
@aleksandergrzyb asked to re-review this. Small changes, just SwiftLint fixes and Sendable support! |
aleksandergrzyb
approved these changes
Sep 12, 2025
pepicrft
reviewed
Sep 15, 2025
| let totalNumberOfTestFailures = primaryObservable["totalNumberOfTestFailures"] as? Int, | ||
| let highLevelStatus = primaryObservable["highLevelStatus"] as? String | ||
| else { | ||
| throw LogError.invalidLogManifest("The file at \(path) is not a valid " + |
Collaborator
There was a problem hiding this comment.
If we throw if those metrics are absent, and per your comment it's a change in a recent Xcode version, won't this be a breaking change for developers using this library with older Xcode versions? If so, I recommend to making statistics optional, and then add a comment for future reference where we indicate from which version of Xcode the attribute becomes present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated
LogManifestEntryfor Xcode's latest format, adding statistics like number of warnings and errors. This allows to filter out failed builds without loading.xcactivitylog.I've also changed the build duration from an
Intinto aDoubleand removed the rounding, so build durations are more precise. I believe it's up to the users of the framework to decide to round the build duration instead of us showing wrong build durations from the start.