Proposal: Make Linux Builds Portable #164
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
PatrikBillgren
left a comment
There was a problem hiding this comment.
Thanks for submitting the PR! Supporting this use case sounds good to me. Do you have possibility to extend the PR with the functionality you described for creating two artifacts?
bce2033 to
a8aaaeb
Compare
Signed-off-by: Jeremy Massel <1123407+jkmassel@users.noreply.github.com>
a8aaaeb to
2fd4414
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposal for portable Linux builds – right now it's not possible to simply download the release binary from a tag and run it on Linux without the swift standard library.
I suspect it might be preferable to produce two build artifacts – one smaller dynamically-linked version, and this larger statically-linked version.
Portability only goes so far – a quick test shows that it works on these (dockerized) distros (as tested by running
xclogparser version):But does not work on:
Happy to hear y'alls thoughts on this!
Note: I needed to modify the
Dockerfileto makebuild_release_in_docker.shwork – otherwise SPM would fail.