correct the env name for mcp param override #741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b38d8a6 to
29a7e75
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect environment variable names used for overriding MCP parameters. The code was using MC_ORG_ID and MC_PROJ_ID instead of the correct MM_ORG_ID and MM_PROJ_ID names.
Key Changes:
- Corrected environment variable names from
MC_*toMM_*prefix in the_override_with_env_if_existsmethod - Added unit tests to verify the environment variable overrides work correctly for
org_idandproj_id - Updated the test fixture to properly cleanup all three environment variables
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/memmachine/server/api_v2/mcp.py | Fixed environment variable names from MC_ORG_ID/MC_PROJ_ID to MM_ORG_ID/MM_PROJ_ID |
| tests/memmachine/server/api_v2/test_mcp.py | Added tests for org_id and proj_id environment overrides and updated cleanup fixture |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
o-love
approved these changes
Dec 9, 2025
The env variable name that overrides the parameters in mcp is not correct. Fix them to use the correct env variable names. Add unittest to check that.
29a7e75 to
653ba83
Compare
jgong
approved these changes
Dec 10, 2025
edwinyyyu
pushed a commit
to edwinyyyu/MemMachine
that referenced
this pull request
Dec 16, 2025
fixes incorrect environment variable names used for overriding MCP parameters. The code was using `MC_ORG_ID` and `MC_PROJ_ID` instead of the correct `MM_ORG_ID` and `MM_PROJ_ID` names. Key Changes: - Corrected environment variable names from `MC_*` to `MM_*` prefix in the _override_with_env_if_exists method - Added unit tests to verify environment variable overrides work correctly for `org_id` and `proj_id` - Updated test fixture to properly clean up all three environment variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the change
The env variable name that overrides the parameters in mcp is not correct. Fix them to use the correct env variable names.
Add unittest to check that.
Type of change
How Has This Been Tested?
Checklist
Maintainer Checklist