-
Notifications
You must be signed in to change notification settings - Fork 129
Update asyncpg version. #648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Scargall <37674041+sscargal@users.noreply.github.com>
Contributor
Author
|
MemMachine starts successfully using the new Docker image (CPU) List of Docker Images Confirm the image ID |
Closed
jgong
approved these changes
Dec 2, 2025
Contributor
jgong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Steve!
jealous
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the change
Update asyncpg to an official release. Allows
build-docker.shandmemmachine-compose.sh buildto work.Description
The
pyproject.tomlincluded a GitHub commit version ofasyncpg, which caused the Docker image build pipeline to fail as the base image didn't includegit. The changes in the asyncpg commit have been merged into v0.31.0, so we removed the explicit commit version and bumped the minimum asyncpg version.Fixes/Closes
Fixes #637
Type of change
How Has This Been Tested?
I can successfully run
build-docker.shandmemmachine-compose.sh build.Logs:
Checklist
Maintainer Checklist
Screenshots/Gifs
See logs above
Further comments
MemMachine starts successfully using the locally built Docker images.
Only tested on Linux. Needs verification on Windows and Mac OS X.