Fix deleting session episodes v1 #532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
jealous
approved these changes
Nov 17, 2025
malatewang
approved these changes
Nov 17, 2025
o-love
pushed a commit
that referenced
this pull request
Nov 19, 2025
* Fix deleting session episodes v1 Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> * Fix style Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> --------- Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Co-authored-by: Cedric Zhuang <cedric.zhuang@memverge.com> # Conflicts: # src/memmachine/episodic_memory/long_term_memory/long_term_memory.py Language generation models do not take dimensions Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> fix test error for language model Update VectorGraphStore configuration Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Replace vendor by provider Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Disable server tests during refactor Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix greenlet dependency issue Fix asyncpg on Windows with Python 3.14 Fix tzdata for Windows Remove psycopg2 Fix ruff check Fix complexipy lint Fix complexipy lint Fix mypy errors Add ruff complexity check Ruff exclude tools Fix datetime usage Add more linters Continue fmt and doc fixing Continue fixing lint issues Continue addressing lint issues Continue fmt work Fix ruff Fix unit tests Ruff fixes Resolve ruff config Fix tools on windows Fix more mypy errors Ruff fmt Fix semantic prompt unit test Replace 'OpenAI-compatible' with 'OpenAI Chat Completions' Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix OpenAIChatCompletionsLanguageModel test Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix reranker conf test Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix and improve model configurations Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Case-sensitive providers for consistency Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Update sample configs to be closer to desired Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Rename model_conf to language_model_conf Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Replace all JSONValue with Pydantic JsonValue Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix db uningested retrieval Update config Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Update config Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Update config Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> support both neo4j and pq for semantic memory. also rename some history storage to episodic storage Type fixes Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix mypy issues in semantic memory Fix github workflow Fix github workflow Fix github workflow Fix github workflow Ruff fix Fix mypy semantic errors rename storage to database Consistently use uid: str instead of uuid: UUID Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Rename History to Episode # Conflicts: # src/memmachine/episode_store/episode_sqlalchemy_store.py # tests/memmachine/episode_store/test_episode_storage.py Ruff fmt Fix episode store integration test on postgres Fix ruff issues in episode_store Fix unit test problem (#540) Fix Neo4jVectorGraphStore typing Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix mypy This probably fixes something Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix OpenAI Response typing Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Add float and datetime to FilterablePropertyValue Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Miscellaneous type fixes Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Add missing await to episode deletion Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Devibe Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> More type fixes Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix more typing Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Mangle filterable metadata keys when translating from external to internal Episode type Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Solve weighted index proximity binding type and lint errors Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Improve weighted index proximity binding Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix typing and lint issues in Neo4jVectorGraphStore Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Miscellaneous lint fix Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Miscellaneous lint fix Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Miscellaneous lint fix Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> All 'Neo4J' should be 'Neo4j' Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> use database for session manager. fix ruff format/check errors Fix some mypy error (#541) Signed-off-by: Shu Wang <33640803+malatewang@users.noreply.github.com> fix mypy errors for configuration/manager fix ruff format in test_database_manager.pyt Clean episode store after each test
o-love
pushed a commit
that referenced
this pull request
Nov 19, 2025
* Fix deleting session episodes v1 Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> * Fix style Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> --------- Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Co-authored-by: Cedric Zhuang <cedric.zhuang@memverge.com> # Conflicts: # src/memmachine/episodic_memory/long_term_memory/long_term_memory.py Language generation models do not take dimensions Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> fix test error for language model Update VectorGraphStore configuration Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Replace vendor by provider Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Disable server tests during refactor Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix greenlet dependency issue Fix asyncpg on Windows with Python 3.14 Fix tzdata for Windows Remove psycopg2 Fix ruff check Fix complexipy lint Fix complexipy lint Fix mypy errors Add ruff complexity check Ruff exclude tools Fix datetime usage Add more linters Continue fmt and doc fixing Continue fixing lint issues Continue addressing lint issues Continue fmt work Fix ruff Fix unit tests Ruff fixes Resolve ruff config Fix tools on windows Fix more mypy errors Ruff fmt Fix semantic prompt unit test Replace 'OpenAI-compatible' with 'OpenAI Chat Completions' Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix OpenAIChatCompletionsLanguageModel test Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix reranker conf test Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix and improve model configurations Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Case-sensitive providers for consistency Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Update sample configs to be closer to desired Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Rename model_conf to language_model_conf Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Replace all JSONValue with Pydantic JsonValue Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix db uningested retrieval Update config Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Update config Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Update config Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> support both neo4j and pq for semantic memory. also rename some history storage to episodic storage Type fixes Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix mypy issues in semantic memory Fix github workflow Fix github workflow Fix github workflow Fix github workflow Ruff fix Fix mypy semantic errors rename storage to database Consistently use uid: str instead of uuid: UUID Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Rename History to Episode # Conflicts: # src/memmachine/episode_store/episode_sqlalchemy_store.py # tests/memmachine/episode_store/test_episode_storage.py Ruff fmt Fix episode store integration test on postgres Fix ruff issues in episode_store Fix unit test problem (#540) Fix Neo4jVectorGraphStore typing Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix mypy This probably fixes something Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix OpenAI Response typing Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Add float and datetime to FilterablePropertyValue Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Miscellaneous type fixes Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Add missing await to episode deletion Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Devibe Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> More type fixes Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix more typing Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Mangle filterable metadata keys when translating from external to internal Episode type Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Solve weighted index proximity binding type and lint errors Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Improve weighted index proximity binding Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix typing and lint issues in Neo4jVectorGraphStore Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Miscellaneous lint fix Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Miscellaneous lint fix Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Miscellaneous lint fix Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> All 'Neo4J' should be 'Neo4j' Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> use database for session manager. fix ruff format/check errors Fix some mypy error (#541) Signed-off-by: Shu Wang <33640803+malatewang@users.noreply.github.com> fix mypy errors for configuration/manager fix ruff format in test_database_manager.pyt Clean episode store after each test
o-love
pushed a commit
that referenced
this pull request
Nov 19, 2025
* Fix deleting session episodes v1 Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> * Fix style Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> --------- Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Co-authored-by: Cedric Zhuang <cedric.zhuang@memverge.com> # Conflicts: # src/memmachine/episodic_memory/long_term_memory/long_term_memory.py Language generation models do not take dimensions Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> fix test error for language model Update VectorGraphStore configuration Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Replace vendor by provider Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Disable server tests during refactor Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix greenlet dependency issue Fix asyncpg on Windows with Python 3.14 Fix tzdata for Windows Remove psycopg2 Fix ruff check Fix complexipy lint Fix complexipy lint Fix mypy errors Add ruff complexity check Ruff exclude tools Fix datetime usage Add more linters Continue fmt and doc fixing Continue fixing lint issues Continue addressing lint issues Continue fmt work Fix ruff Fix unit tests Ruff fixes Resolve ruff config Fix tools on windows Fix more mypy errors Ruff fmt Fix semantic prompt unit test Replace 'OpenAI-compatible' with 'OpenAI Chat Completions' Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix OpenAIChatCompletionsLanguageModel test Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix reranker conf test Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix and improve model configurations Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Case-sensitive providers for consistency Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Update sample configs to be closer to desired Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Rename model_conf to language_model_conf Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Replace all JSONValue with Pydantic JsonValue Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix db uningested retrieval Update config Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Update config Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Update config Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> support both neo4j and pq for semantic memory. also rename some history storage to episodic storage Type fixes Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix mypy issues in semantic memory Fix github workflow Fix github workflow Fix github workflow Fix github workflow Ruff fix Fix mypy semantic errors rename storage to database Consistently use uid: str instead of uuid: UUID Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Rename History to Episode # Conflicts: # src/memmachine/episode_store/episode_sqlalchemy_store.py # tests/memmachine/episode_store/test_episode_storage.py Ruff fmt Fix episode store integration test on postgres Fix ruff issues in episode_store Fix unit test problem (#540) Fix Neo4jVectorGraphStore typing Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix mypy This probably fixes something Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix OpenAI Response typing Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Add float and datetime to FilterablePropertyValue Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Miscellaneous type fixes Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Add missing await to episode deletion Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Devibe Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> More type fixes Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix more typing Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Mangle filterable metadata keys when translating from external to internal Episode type Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Solve weighted index proximity binding type and lint errors Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Improve weighted index proximity binding Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Fix typing and lint issues in Neo4jVectorGraphStore Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Miscellaneous lint fix Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Miscellaneous lint fix Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> Miscellaneous lint fix Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> All 'Neo4J' should be 'Neo4j' Signed-off-by: Edwin Yu <edwinyyyu@gmail.com> use database for session manager. fix ruff format/check errors Fix some mypy error (#541) Signed-off-by: Shu Wang <33640803+malatewang@users.noreply.github.com> fix mypy errors for configuration/manager fix ruff format in test_database_manager.pyt Clean episode store after each test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the change
Session deletion doesn't work because LongTermMemory no longer has _memory_context.
Description
Set _session_id in initializer and use it to filter sessions.
Fixes/Closes
Fixes #533
Type of change