Skip to content

Conversation

@tomw-mv
Copy link
Contributor

@tomw-mv tomw-mv commented Nov 7, 2025

Purpose of the change

Fix bug in tools/chatgpt2memmachine/migration.py
convert string to timestamp

Description

Fix bug in tools/chatgpt2memmachine/migration.py
convert string to timestamp

No dependencies

Fixes/Closes

Fixes #497

Type of change

[Please delete options that are not relevant.]

  • [ x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

[Please delete options that are not relevant.]

  • [ x] Unit Test

Test Results: [Attach logs, screenshots, or relevant output]

[memmachine@ai1 MemMachine]$ uv run pytest tools/chatgpt2memmachine/
============================================== test session starts ===============================================
platform linux -- Python 3.12.12, pytest-8.4.2, pluggy-1.6.0
rootdir: /home/memmachine/MemMachine
configfile: pyproject.toml
plugins: asyncio-1.2.0, langsmith-0.4.37, anyio-4.11.0
asyncio: mode=Mode.STRICT, debug=False, asyncio_default_fixture_loop_scope=session, asyncio_default_test_loop_scope=session
collected 1 item

tools/chatgpt2memmachine/test_migration.py . [100%]

=============================================== 1 passed in 0.18s ================================================

Checklist

[Please delete options that are not relevant.]

  • [ x] I have signed the commit(s) within this pull request
  • [ x] My code follows the style guidelines of this project (See STYLE_GUIDE.md)
  • [ x] I have performed a self-review of my own code
  • [ x] My changes generate no new warnings
  • [ x] New and existing unit tests pass locally with my changes

Maintainer Checklist

  • Confirmed all checks passed
  • Contributor has signed the commit(s)
  • Reviewed the code
  • Run, Tested, and Verified the change(s) work as expected

Screenshots/Gifs

[If applicable, add screenshots or GIFs that show the changes in action. This is especially helpful for API responses. Otherwise, delete this section or type "N/A".]

Further comments

[Add any other relevant information here, such as potential side effects, future considerations, or any specific questions for the reviewer. Otherwise, type "None".]

…amp #497

Signed-off-by: Tom Wong <tom.wong@memverge.com>
@tomw-mv tomw-mv requested review from a team and jgong November 7, 2025 23:00
Copy link
Contributor

@jgong jgong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Copy link
Contributor

@sscargal sscargal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sscargal sscargal merged commit 5f277ff into MemMachine:main Nov 8, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: hackthon chatgpt2memmachine not converting time string to timestamp

3 participants