download_queue: tweak progress output. #21357
Merged
+5
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use a more `curl`-like character to better emulate pre-download queue Homebrew - Don't display the download progress if we don't have a total size (yet or at all) as it won't ever progress
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the download progress display to be more curl-like and cleaner by changing the progress bar character from dashes to spaces, and by only showing the progress bar when the total download size is known.
- Changed the progress bar pending character from
-to - Added logic to only display the progress bar during downloading when
total_sizeis available - Refactored
total_sizeextraction to avoid duplicate method calls
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
p-linnane
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
curl-like character to better emulate pre-download queue Homebrew