Improve Tab.for_name to use keg where possible.
#21354
Merged
+16
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed a tiny performance improvement here where we can avoid creating a `Formula` when loading a Tab from a name/rack path.
5 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes Tab.for_name to avoid unnecessarily creating a Formula object when loading a Tab from a name/rack path, by preferring to use a Keg directly when one is available.
- Extracts common keg selection logic from
Formulary.from_rackinto a newKeg.from_rackmethod - Modifies
Tab.for_nameto callKeg.from_rackfirst and only fall back toFormulary.from_rackwhen no keg exists - Updates
Formulary.from_rackto accept an optionalkegparameter to avoid redundant keg lookups
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Library/Homebrew/keg.rb | Adds new Keg.from_rack class method that returns the linked, optlinked, or latest keg from a rack |
| Library/Homebrew/tab.rb | Refactors Tab.for_name to use Keg.from_rack first, avoiding formula creation when a keg is found |
| Library/Homebrew/formulary.rb | Updates from_rack to accept optional keg parameter with default value, eliminating duplicate keg selection logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a tiny performance improvement here when reviewing #21351 where we can avoid creating a
Formulawhen loading a Tab from a name/rack path.