修复无法解析类似 "26.1 Snapshot 1" 的版本号的问题 #5002
Merged
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the inability to parse version numbers with human-readable snapshot format like "26.1 Snapshot 1". The fix enables the parser to recognize and normalize this format to the canonical form "26.1-snapshot-1".
- Adds parsing support for " Snapshot " format in version strings
- Ensures proper normalization to the canonical "-snapshot-" format
- Includes test coverage for the new parsing capability
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| HMCLCore/src/main/java/org/jackhuang/hmcl/util/versioning/GameVersionNumber.java | Adds parsing logic for " Snapshot " prefix, following the same pattern as existing "Pre-Release" and "Release Candidate" handling |
| HMCLCore/src/test/java/org/jackhuang/hmcl/util/versioning/GameVersionNumberTest.java | Adds test case to verify "26.1 Snapshot 1" normalizes to "26.1-snapshot-1" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Glavo
added a commit
to Glavo/HMCL
that referenced
this pull request
Dec 20, 2025
Glavo
added a commit
that referenced
this pull request
Dec 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.