feat: DB v2 snapshot db tests #98
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandryllo
commented
Dec 17, 2025
| assert.strictEqual( | ||
| database.name, | ||
| `${ctx.config.appName}-default`, | ||
| `${ctx.config.appName}-default-db`, |
Collaborator
Author
There was a problem hiding this comment.
This change is here because I changed how databases are named inside this PR (see infrastructure file), as this should be the last PR regarding tests. I can move this to previous PR's if needed
febb6cd to
6f9884f
Compare
de7b20d to
e273136
Compare
bornast
requested changes
Jan 2, 2026
|
|
||
| export { vpc, defaultDb, kms, paramGroup, customDb }; | ||
| const snapshot = defaultDb.instance.dbInstanceIdentifier.apply( | ||
| dbInstanceIdentifier => { |
Member
There was a problem hiding this comment.
dbInstanceIdentifier implicitly has any type
| }, | ||
| ); | ||
|
|
||
| const snapshotDb = snapshot.apply(snapshot => { |
Member
There was a problem hiding this comment.
snaphost implicitly has any type
Member
There was a problem hiding this comment.
We should also add a test to see if we can access the db.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fifth PR in order to resolve #70 , it introduces integration tests for db created from a snapshot