Update to .NET Core 3#300
Closed
raz-canva wants to merge 3 commits intoElectronNET:masterfrom
raz-canva:raz/dotnet-core-preview-7-with-packages
Closed
Update to .NET Core 3#300raz-canva wants to merge 3 commits intoElectronNET:masterfrom raz-canva:raz/dotnet-core-preview-7-with-packages
raz-canva wants to merge 3 commits intoElectronNET:masterfrom
raz-canva:raz/dotnet-core-preview-7-with-packages
Conversation
Contributor
|
For .NET Core 3.0 RTM working you need this to your PR:
<TargetFramework>netcoreapp3.0</TargetFramework>
<AspNetCoreHostingModel>OutOfProcess</AspNetCoreHostingModel>
<AspNetCoreModuleName>AspNetCoreModule</AspNetCoreModuleName>
|
Author
|
Would anyone be able to take over this PR? I think it is pretty close to functioning |
Merged
Collaborator
|
I was unable to pull this PR - maybe because you deleted the original branch? I (more or less) applied the same changes to a new branch and if everything works out, I might put up a beta with .NET Core 3 support on NuGet. |
Contributor
|
Hi @robertmuehsig , can you also take a look at my PR about AddExtension if you publish a beta ? I need this for my BlazorMobile plugin, it would be highly appreciated as it is blocking my ElectronNet implementation. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using .NET Core 3
Remove unused packages