Skip to content

initial update for .net core 3 preview2#221

Closed
ErikApption wants to merge 1 commit intoElectronNET:masterfrom
ErikApption:netcore3preview
Closed

initial update for .net core 3 preview2#221
ErikApption wants to merge 1 commit intoElectronNET:masterfrom
ErikApption:netcore3preview

Conversation

@ErikApption
Copy link
Copy Markdown

Runs electron.net with .net core 3 preview

@MaherJendoubi
Copy link
Copy Markdown
Contributor

MaherJendoubi commented May 16, 2019

@ErikApption I wonder to know why not using the latest preview 5 of .NET Core 3

Copy link
Copy Markdown
Collaborator

@robertmuehsig robertmuehsig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any simple guide how to support netcoreapp2.1 and netcoreapp3.0? I'm open to support netcore3.0, but it should affect "older" versions that are currently in use.

@MaherJendoubi
Copy link
Copy Markdown
Contributor

@robertmuehsig
Copy link
Copy Markdown
Collaborator

Thats not what I asked. What do we need to do (during NuGet packaging etc.) to support netcore2.2 and netcore3.0? I know there are some long blogposts out there and when netcore3.0 is "mature" enough we will do this step, but until then I would need some good advice.

@MaherJendoubi
Copy link
Copy Markdown
Contributor

You need to ship 2 different NuGet packages for instance 5.22.13 for netcoreapp2.2 and 5.30.13 for netcoreapp3.0. You could keep the master branch for netcoreapp3.0 and a second branch for netcoreapp2.2.

@robertmuehsig
Copy link
Copy Markdown
Collaborator

Checkout #313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants