Fix some bugs and add animations to ProfileMusicView #1893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, This PR fixes several UI issues and enhances animations in the
ProfileMusicViewcomponent. Here's what I've changed:Fixes
Fix: Online text view centering issue
Online text view had left padding that prevented proper centering, now it's perfectly centered. Sorry for that :D
Fix: Music replacement logic
When we have multiple music tracks on profile, from my profile page, deleting the top music from profile causes the music view to disappear completely. It should be replaced with the next music in the playlist instead.
Fix: Avatar collapse animation glitch
Based on the
minimizedXchanges (fromdp(42 + 21)todp(42 + 4)), the newminimizedXvalue now also applies insetAvatarExpandProgress. This affects scenarios where users fast scroll up while the avatar is already expanded, which causes a glitch if the new value doesn't apply during the animation.Added Animations
Added: Music switching animation
Switching the top music in my profile page now includes a smooth translation animation (previous track slides down while the new music data slides in from the top)
Scenario to test:
Add multiple music tracks to your profile, then try to move and switch the top music from your profile page, or simply remove the top music from profile. It should smoothly animate to the next music.
Added: Music removal animation
Removing music from profile now makes the music player resize smoothly (animates height to zero) during the removal process. Before this PR, there was a minor glitch during this process.
Scenario to test:
Go to my profile page, remove the music from your profile and observe the transition.
Added: Music addition animation
Adding music to profile now makes the music player resize with animation (height changes from zero to its target height) as it enters. Before this PR, there was a minor glitch during this interaction.
Scenario to test: