Improve Proxy Rotation: Connect to First Available Proxy Without Waiting for All Pings #1881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves proxy switching logic by connecting to the first proxy that responds, instead of waiting for all proxy pings to complete. - Adds hasSwitched flag to prevent multiple switches - Speeds up failover and improves user experience with unreliable proxies
Ensure hasSwitched is reset in switchToAvailable() to prevent stale flag from blocking future proxy switches after failed or skipped checks.
- Documented class purpose, fields, and methods - Explained logic for proxy checking, switching, and notification handling - Clarified rotation fallback and concurrency safeguards - Improved readability and maintainability for future development
|
It looks like you used ChatGPT to generate the code. |
|
😐 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Pull Request Description:
This PR improves the proxy rotation mechanism in Telegram by reducing delay when switching proxies.
✨ Changes:
Immediately connects to the first available proxy once it successfully responds to a ping.
Avoids waiting for all proxy ping checks to complete before switching.
Uses a hasSwitched flag to ensure only one switch happens per rotation check.
Retains switchToAvailable() as a fallback if no proxy responds.
📈 Benefits:
Much faster proxy switching during network instability or failover.
Better experience in regions with partial blocking or when using unreliable proxies.
Reduces unnecessary wait times by prioritizing responsiveness over completeness.