Skip to content

Improve composer.json#2

Merged
jasdeepkhalsa merged 3 commits intoDBDiff:masterfrom
chadrien:patch-2
Mar 24, 2016
Merged

Improve composer.json#2
jasdeepkhalsa merged 3 commits intoDBDiff:masterfrom
chadrien:patch-2

Conversation

@chadrien
Copy link
Copy Markdown
Contributor

No description provided.

@jasdeepkhalsa
Copy link
Copy Markdown
Member

Great suggestion @chadrien ! I only just saw your pull request now, will review and merge in soon (give me a few days)

@jasdeepkhalsa jasdeepkhalsa merged commit 844abec into DBDiff:master Mar 24, 2016
@chadrien
Copy link
Copy Markdown
Contributor Author

🎉 🙂

@chadrien chadrien deleted the patch-2 branch March 25, 2016 11:51
@ishmaelen ishmaelen mentioned this pull request Dec 28, 2016
jasdeepkhalsa added a commit that referenced this pull request Mar 25, 2026
…taSQL

getDown() previously called getOldValue() unconditionally, which crashes
with a fatal error when the diff contains DiffOpAdd objects (which lack
that method). Also, getDown() did not null-guard getOldValue(), causing
NULL column values to be written as empty strings instead of SQL NULL.

Both getUp() and getDown() now:
- Check for DiffOpAdd/DiffOpRemove to avoid calling missing methods
- Null-guard return values to emit col = NULL instead of col = ''

Added comprehensive unit tests covering DiffOpChange, DiffOpAdd,
DiffOpRemove, null values, and mixed DiffOp types in a single UPDATE.

Refs: bugs.md Bug #2, Bug #9, PR #93
jasdeepkhalsa added a commit that referenced this pull request Mar 25, 2026
Add a Fix Status summary table at the top of bugs.md documenting:
- Commit hash for each bug fix
- Brief description of what was changed
- Test file references
- Note that bugs #2 and #9 were combined (same file/method)

Original bug detail table preserved below for reference.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants