Improve composer.json#2
Merged
jasdeepkhalsa merged 3 commits intoDBDiff:masterfrom Mar 24, 2016
chadrien:patch-2
Merged
Conversation
Member
|
Great suggestion @chadrien ! I only just saw your pull request now, will review and merge in soon (give me a few days) |
Contributor
Author
|
🎉 🙂 |
Closed
jasdeepkhalsa
added a commit
that referenced
this pull request
Mar 25, 2026
…taSQL getDown() previously called getOldValue() unconditionally, which crashes with a fatal error when the diff contains DiffOpAdd objects (which lack that method). Also, getDown() did not null-guard getOldValue(), causing NULL column values to be written as empty strings instead of SQL NULL. Both getUp() and getDown() now: - Check for DiffOpAdd/DiffOpRemove to avoid calling missing methods - Null-guard return values to emit col = NULL instead of col = '' Added comprehensive unit tests covering DiffOpChange, DiffOpAdd, DiffOpRemove, null values, and mixed DiffOp types in a single UPDATE. Refs: bugs.md Bug #2, Bug #9, PR #93
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.