fix(release): use correct micro.sfx filename on Windows#172
Merged
jasdeepkhalsa merged 1 commit intomasterfrom Apr 3, 2026
Merged
fix(release): use correct micro.sfx filename on Windows#172jasdeepkhalsa merged 1 commit intomasterfrom
jasdeepkhalsa merged 1 commit intomasterfrom
Conversation
SPC deploys the micro SAPI to buildroot/bin/micro.sfx on all platforms including Windows — the filename has no .exe extension. The Windows combine step was referencing micro.sfx.exe which does not exist. Fixes: Combine PHP + PHAR → binary (Windows) step failure.
|
Member
Author
|
Merged quickly due to workflow only changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(release): correct
micro.sfxfilename on WindowsProblem
The "Combine PHP + PHAR → binary (Windows)" step failed with:
Root cause
SPC's
WindowsBuilder::deploySAPIBinary()copies the built micro SAPI tobuildroot\bin\micro.sfxon all platforms — the filename has no.exeextension, even on Windows. Both
release.ymlandrelease-dry-run.ymlincorrectly referenced
micro.sfx.exe.Confirmed by the SPC docs:
And by
WindowsBuilder.php—deploySAPIBinary()deploysmicro.sfx(no.exe) regardless of platform.Fix
Changed
buildroot\bin\micro.sfx.exe→buildroot\bin\micro.sfxin theWindows combine step of both workflows.
Files changed
.github/workflows/release.yml.github/workflows/release-dry-run.yml