fix: add zlib to SPC_WINDOWS_LIBS; drop win32-arm64 target#148
Merged
jasdeepkhalsa merged 1 commit intomasterfrom Mar 7, 2026
Merged
fix: add zlib to SPC_WINDOWS_LIBS; drop win32-arm64 target#148jasdeepkhalsa merged 1 commit intomasterfrom
jasdeepkhalsa merged 1 commit intomasterfrom
Conversation
win32-x64: linker fails with 14 unresolved zlib symbols (compress, uncompress, deflate, inflate, gzdopen, etc.) because zlib is in SPC_EXTENSIONS but not SPC_WINDOWS_LIBS. On Windows there is no system zlib, so it must be listed explicitly for SPC to download and link zlib_a.lib. Fix: prepend zlib to SPC_WINDOWS_LIBS. win32-arm64: SPC v2.8.2 hard-codes phpsdk-vs17-x64.bat, which passes 'x64_amd64' to vcvarsall.bat — an invalid argument on an ARM64 host (valid are amd64_arm64 etc.). It also always downloads the postgresql-16-windows-x64-binaries.zip regardless of runner arch. These are upstream SPC bugs; drop the target from the matrix and the publish step until SPC gains proper Windows ARM64 support. The npm package @dbdiff/cli-win32-arm64 skeleton is kept in place so arm64 Windows users get a clean 'Could not locate binary' error rather than an npm install failure.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
win32-x64: linker fails with 14 unresolved zlib symbols (compress, uncompress, deflate, inflate, gzdopen, etc.) because zlib is in SPC_EXTENSIONS but not SPC_WINDOWS_LIBS. On Windows there is no system zlib, so it must be listed explicitly for SPC to download and link zlib_a.lib. Fix: prepend zlib to SPC_WINDOWS_LIBS.
win32-arm64: SPC v2.8.2 hard-codes phpsdk-vs17-x64.bat, which passes 'x64_amd64' to vcvarsall.bat — an invalid argument on an ARM64 host (valid are amd64_arm64 etc.). It also always downloads the postgresql-16-windows-x64-binaries.zip regardless of runner arch. These are upstream SPC bugs; drop the target from the matrix and the publish step until SPC gains proper Windows ARM64 support. The npm package @dbdiff/cli-win32-arm64 skeleton is kept in place so arm64 Windows users get a clean 'Could not locate binary' error rather than an npm install failure.