Fixing Windows Builds - Adding Debug#147
Merged
jasdeepkhalsa merged 2 commits intomasterfrom Mar 7, 2026
Merged
Conversation
packages/@dbdiff/cli (no slash) + package.json = packages/@dbdiff/clipackage.json ← ENOENT Fix: add trailing slash so it resolves to packages/@dbdiff/cli/package.json
…check - Add --debug to spc.exe build so the actual nmake/cmake compilation error is visible in GHA logs instead of just 'exit code 2' - Fix getBinaryPath() in bin/dbdiff.js to verify the binary file actually exists on disk; previously it returned a non-null path even when the platform package was installed but empty (published without a binary after a failed build), causing an unhelpful ENOENT crash rather than the clear 'Could not locate binary' error message
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to fix Windows builds once again which are essential for
npm installs on WindowsAdds a
--debugflag to find out what may be going wrong, so another PR is sure to follow this one