Fix Windows binary builds and publish job artifact download failure#146
Merged
jasdeepkhalsa merged 3 commits intomasterfrom Mar 7, 2026
Merged
Fix Windows binary builds and publish job artifact download failure#146jasdeepkhalsa merged 3 commits intomasterfrom
jasdeepkhalsa merged 3 commits intomasterfrom
Conversation
SPC Windows builds use pre-built VC++ packages registered under the -win suffix. Bare names (postgresql/libiconv) download Unix source archives, never locking postgresql-win/libiconv-win, so build fails with "not downloaded or not locked".
PHP 8.1 was already in unit tests but missing from MySQL, SQLite, and PostgreSQL integration matrices. PHP 8.2 was absent from everything despite composer.json declaring >=8.1 as the floor. - tests.yml: all four matrices now cover [8.1, 8.2, 8.3, 8.4, 8.5] - docker-compose.yml: add cli-php81-* and cli-php82-* service blocks - start.sh: add PHP_VERSION_81/82 defaults, include in PHP_VERSIONS array, update fallback default, add CLI service echo entries - README.md: CI matrix count 4x4=16 -> 6x4=24 - DOCKER.md: add 8.1 and 8.2 to PHP versions and service lists
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fix Windows binary builds and publish job artifact download failure
win32-x64 / win32-arm64 — wrong library names in
spc downloadRoot cause:
SPC_WINDOWS_LIBSused bare namespostgresqlandlibiconv,which download the Unix source tarballs and register download locks under those
names. SPC's Windows build system then looks for
postgresql-winandlibiconv-win(pre-built Visual C++ binary packages), finds no lock entry, andfails immediately:
Fix: Use the correct Windows package names in
SPC_WINDOWS_LIBS:libxml2andsqliteare built from source on all platforms and have no-winvariant.Publish job — Docker build-cache artifacts crash the download step
Root cause: The
download-artifactstep had nopatternfilter, so itattempted to download every artifact in the run — including
DBDiff~DBDiff~*.dockerbuildbuild-cache blobs uploaded by the Docker job.Those are internal BuildKit cache references that cannot be downloaded as normal
artifacts, causing:
This killed the entire publish job even when all required
dbdiff-*artifactswere available.
Fix: Add
pattern: dbdiff-*to thedownload-artifactstep so only PHARand binary artifacts are fetched: