Skip to content

Conversation

@pull
Copy link

@pull pull bot commented Sep 11, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

…1872)

* Update PSScriptAnalyzer.psm1

* use latest patch version 7.2.11
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Sep 11, 2023
@pull pull bot added ⤵️ pull and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Sep 11, 2023
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Sep 11, 2023
bergmeister and others added 25 commits September 11, 2023 13:07
* Remove unused variables

* simplify code and remove unused method

* remove unused member

* more cleanup

* more cleanup

* more

* more
* PSReservedParams - link about_CommonParameters

Knowing that I'm not allowed to use certain words is more helpful if I have a list of those forbidden words.

* Update docs/Rules/ReservedParams.md

* change link markdown to reference-style syntax

Co-authored-by: Mikey Lombardi (He/Him) <michael.t.lombardi@gmail.com>

---------

Co-authored-by: Christoph Bergmeister <c.bergmeister@gmail.com>
Co-authored-by: Mikey Lombardi (He/Him) <michael.t.lombardi@gmail.com>
…ic variable or parameter (#1896)

* add ruleId to PSAvoidAssignmentToAutomaticVariable

Enables suppression for specific variable/parameter.
Fix #1589

* add tests
* add ErrorView to SpecialVars and create test

* Changed type of ErrorView
* first working version

* cleanup

* apply change to rules project as well
* Add ruleId to PSUseSingularNouns

* Update UseSingularNouns.md

* Update UseSingularNouns.md

---------

Co-authored-by: Christoph Bergmeister <c.bergmeister@gmail.com>
#1946)

* Adding DiagnosticRecord.ToString() (Fixes #1945)

* Adding CorrectionExtent.ToString() (Fixes #1944)

---------

Co-authored-by: James Brundage <@github.com>
Many analysis objects here have null Type field value. This leads to premature exiting the method.
…wlist (#1858)

* Add Windows to the UseSingularNouns allow list

* Add test case for Windows verb

* Refactor UseSingularNouns to configurable rule and add tests

* Update UseSingularNouns docs with configuration information

* Remove extra test code

---------

Co-authored-by: Christoph Bergmeister <c.bergmeister@gmail.com>
* Bump Newtonsoft.Json from 12.0.3 to 13.0.2

Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 12.0.3 to 13.0.2.
- [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases)
- [Commits](JamesNK/Newtonsoft.Json@12.0.3...13.0.2)

---
updated-dependencies:
- dependency-name: Newtonsoft.Json
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Apply suggestions from code review

* Bump all version to 13.0.3

* Apply suggestions from code review

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Christoph Bergmeister <c.bergmeister@gmail.com>
….NET 6 as well (#1955)

* Update global.json

* Update README.md

* Update Dockerfile

* Update devcontainer.json

* Update devcontainer.json

* Update devcontainer.json

* Update global.json
…rShell 7 only (#1947)

* Bump Microsoft.Management.Infrastructure from 1.0.0 to 3.0.0

Bumps [Microsoft.Management.Infrastructure](https://github.com/PowerShell/MMI) from 1.0.0 to 3.0.0.
- [Commits](https://github.com/PowerShell/MMI/commits)

---
updated-dependencies:
- dependency-name: Microsoft.Management.Infrastructure
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update PSCompatibilityCollector/Microsoft.PowerShell.CrossCompatibility/Microsoft.PowerShell.CrossCompatibility.csproj

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Christoph Bergmeister <c.bergmeister@gmail.com>
…id having az in default CommandAllowList (#1850)

* AvoidUsingPositionalParameter : Check if command has parameters

* fix syntax

* remove unneeded test

* Update Rules/AvoidPositionalParameters.cs
* Added command traversal option

Explicitly included Where-Object and ForEach-Object scriptblocks to also be searched for variable use

* Command traversal check no longer case sensitive

* Extended tests for selective command traversal

* Rename setting to CommandsToTraverse

* Added docs for new configuration: CommandsToTraverse
* Add AvoidUsingAllowUnencryptedAuthentication rule

* Add AvoidUsingAllowUnencryptedAuthentication docs and tests

* Update docs/Rules/AvoidUsingAllowUnencryptedAuthentication.md

Co-authored-by: Christoph Bergmeister <c.bergmeister@gmail.com>

* Fix code review suggestions

* Fix md code styling

* bump rule count in tests again

* Update docs/Rules/AvoidUsingAllowUnencryptedAuthentication.md

---------

Co-authored-by: Christoph Bergmeister <c.bergmeister@gmail.com>
Co-authored-by: Christoph Bergmeister <c.bergmeister2@shell.com>
…icial (#1981)

* Adding OneBranch pipeline YAML config file for OSS_Microsoft_PSSA-Official

* Updates to signing and TSA

* Fix typo

* Fix typo 2

* Fix typo 3

* Update CR feedback

* Revert back to old signing

* Fix source direcctory for credscan

---------

Co-authored-by: OneBranch Resources <ezstart@microsoft.com>
…#1974)

* Update format and grammar of AvoidUsingAllowUnencryptedAuthentication

* Syncing docs changes to all rules

* Update rules to match docs and improve wording
* Updates to signing

* fix files to sign

* sbom changes

* format changes

* Make packaging wait on build

* clarify task display names

* Make sure signing is setup

* move other tasks to restore phase

* move checkout to restore phase

* update container

* move signing to it's own job

* add flag required for newest container

* clarify copy files task displaynames

* reuse existing variable

* removed unneeded code

* Use correct path is signing job

* sign the nupkg

* fix syntax

* Revert "clarify copy files task displaynames"

This reverts commit 1bdc123.

* Disable code sign validation on first job

* search for where OBP put dotnet.exe

* Move SDK search to it's own job

* delete SDK search

* make nupkg signing a todo

* fix nupkg publishing

* try disabling codeql to get signing working per docs

* don't setup signing where not needed

* combine sign and build job

* set version for SBOM

* make comments more accurate

* Apply suggestions from code review

* fix variable name

* address pr comments

---------

Co-authored-by: Aditya Patwardhan <adityap@microsoft.com>
@andyleejordan andyleejordan deleted the branch ConnectionMaster:master August 6, 2024 22:01
@andyleejordan andyleejordan deleted the master branch August 6, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⤵️ pull 🔍 Ready for Review Pull Request is not reviewed yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.