Add e8 rules to ism control so that references work #14022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xeicker
suggested changes
Oct 15, 2025
|
@Mab879: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Xeicker
approved these changes
Oct 16, 2025
jan-cerny
approved these changes
Oct 17, 2025
Collaborator
jan-cerny
left a comment
There was a problem hiding this comment.
The tests /static-checks/rule-identifiers passed for me.
Mab879
added a commit
to Mab879/contest
that referenced
this pull request
Oct 17, 2025
ComplianceAsCode/content#14022 should have this fixed now.
matusmarhefka
pushed a commit
to RHSecurityCompliance/contest
that referenced
this pull request
Oct 17, 2025
ComplianceAsCode/content#14022 should have this fixed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Move e8 rules which missed more to ISM O control so they get references.
Rationale:
Fixes #12423
Fixes #12427
Fixes #12430
Review Hints:
Run contest
/static-checks/rule-identifierson RHEL 8-10. Check (you will have you enabling warnings) that there are no ISM O rules missing references.