Skip to content

Make sure oval service disable macro covers also not found definition #13725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
teacup-on-rockingchair merged 1 commit into from
Jul 22, 2025
Merged

Make sure oval service disable macro covers also not found definition #13725

teacup-on-rockingchair merged 1 commit into from
Jul 22, 2025

Conversation

@teacup-on-rockingchair
Copy link
Contributor

@teacup-on-rockingchair teacup-on-rockingchair commented Jul 18, 2025

Description:

  • Macro oval_test_service_disabled_criteria to cover also case of service is not defined at all

Rationale:

  • In case one wants to check if service is disabled we should cover not only the case of existing disabled service, but also the edge case of such service not defined.

@teacup-on-rockingchair
Make sure oval service disable macro covers also not found definition
9ea42e9 
In case one wants to check if service is disabled we should cover not only the case of existing disabled service,
but also the edge case of such service not defined.
@teacup-on-rockingchair teacup-on-rockingchair added OVAL OVAL update. Related to the systems assessments. Update Template Issues or pull requests related to Templates updates. labels Jul 18, 2025
@teacup-on-rockingchair teacup-on-rockingchair added this to the 0.1.78 milestone Jul 18, 2025
@jan-cerny
Copy link
Collaborator

jan-cerny commented Jul 21, 2025

/packit build

@jan-cerny jan-cerny self-assigned this Jul 21, 2025
jan-cerny
jan-cerny approved these changes Jul 21, 2025
View reviewed changes
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run automatus test scenarios for rules like service_cockpit_disabled and service_bluetooth_disabled and they pass.

@teacup-on-rockingchair teacup-on-rockingchair merged commit fc72965 into ComplianceAsCode:master Jul 22, 2025
137 of 145 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jan-cerny jan-cerny jan-cerny approved these changes

Assignees

@jan-cerny jan-cerny

Labels

OVAL OVAL update. Related to the systems assessments. Update Template Issues or pull requests related to Templates updates.

Projects

None yet

Milestone

0.1.78

Development

Successfully merging this pull request may close these issues.

2 participants

@teacup-on-rockingchair @jan-cerny