Add tags to test scenarios in accounts_root_path_dirs_no_write #13536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rule `accounts_root_path_dirs_no_write` has only Ansible remediation, it doesn't have Bash remediation. Adding `# remediation = ansible` tag will prevent attempts to run the nonexistent Bash remediation.
Mab879
reviewed
Jun 4, 2025
| @@ -1,4 +1,5 @@ | |||
| #!/bin/bash | |||
| # remediation = ansible | |||
Member
There was a problem hiding this comment.
remediation=ansible doesn't make sense for a .pass.sh test
CI fail looks valid.
Addressing: remediation=ansible doesn't make sense for a .pass.sh test
Collaborator
Author
|
I have @jan-cerny Remove remediation tag from a pass scenario |
|
Code Climate has analyzed commit b9850ae and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
Mab879
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rule
accounts_root_path_dirs_no_writehas only Ansible remediation, it doesn't have Bash remediation. Adding# remediation = ansibletag will prevent attempts to run the nonexistent Bash remediation.