Skip to content

Remove file_owner_var_log_messages bash remediation #13488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mab879 merged 2 commits into from
Jun 2, 2025
Merged

Remove file_owner_var_log_messages bash remediation #13488

Mab879 merged 2 commits into from
Jun 2, 2025

Conversation

@mrkanon
Copy link
Contributor

@mrkanon mrkanon commented May 21, 2025

Description:

Rename file_owner_var_log_messages/bash/shared.sh to file_owner_var_log_messages/bash/ubuntu.sh

Rationale:

When a product is not Ubuntu the bash remediation is not generated by the template.

@mrkanon
Properly rename file_owner_var_log_messages bash remediation
37facc9 
Signed-off-by: Armando Acosta <armando.acosta@oracle.com>
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label May 21, 2025
@openshift-ci
Copy link

openshift-ci bot commented May 21, 2025

Hi @mrkanon. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mpurg
Copy link
Contributor

mpurg commented May 22, 2025

I suspect that this file should be removed altogether. All products use the template since #13192.

@mrkanon
Copy link
Contributor Author

mrkanon commented May 22, 2025

I suspect that this file should be removed altogether. All products use the template since #13192.

Ok, then I will remove it

@mrkanon
Remove file_owner_var_log_messages/bash/ubuntu.sh
50191f4 
It remove the bash remediation from file_owner_var_log_messages rule
since all products use the template

Signed-off-by: Armando Acosta <armando.acosta@oracle.com>
@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented May 22, 2025

Code Climate has analyzed commit 50191f4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@mrkanon mrkanon changed the title Rename file_owner_var_log_messages bash remediation Remove file_owner_var_log_messages bash remediation May 23, 2025
@dodys dodys added this to the 0.1.78 milestone May 23, 2025
@Mab879 Mab879 self-assigned this May 30, 2025
@Mab879
Copy link
Member

Mab879 commented May 30, 2025

@dodys Does this look good?

@Mab879 Mab879 added the Bash Bash remediation update. label May 30, 2025
dodys
dodys approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@Mab879 Mab879 merged commit a915aa9 into ComplianceAsCode:master Jun 2, 2025
121 of 122 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mab879 Mab879 Mab879 approved these changes

@dodys dodys dodys approved these changes

Assignees

@Mab879 Mab879

Labels

Bash Bash remediation update. needs-ok-to-test Used by openshift-ci bot.

Projects

None yet

Milestone

0.1.78

Development

Successfully merging this pull request may close these issues.

4 participants

@mrkanon @mpurg @Mab879 @dodys