fixes to grub2 admin user and password rules #13467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-mkconfig The macro currently puts there grubby, which is fine in most cases, but not in this one. Grubby is good when updating kernel parameters.
…t export the variable
|
This datastream diff is auto generated by the check Click here to see the full diffNew content has different text for rule 'xccdf_org.ssgproject.content_rule_grub2_admin_username'.
--- xccdf_org.ssgproject.content_rule_grub2_admin_username
+++ xccdf_org.ssgproject.content_rule_grub2_admin_username
@@ -17,12 +17,15 @@
Change the superuser to a different username (The default is 'root').
$ sed -i 's/\(set superusers=\).*/\1"<unique user ID>"/g' /etc/grub.d/01_users
-
+The line mentioned above must be followed by the line
+export superusers
+so that the superusers is honored.
+
Once the superuser account has been added,
update the
grub.cfg file by running:
-grubby --update-kernel=ALL --env=/boot/grub2/grubenv
+grub-mkconfig -o /boot/grub2/grub.cfg
[warning]:
To prevent hard-coded admin usernames, automatic remediation of this control is not available. Remediation
New content has different text for rule 'xccdf_org.ssgproject.content_rule_grub2_uefi_admin_username'.
--- xccdf_org.ssgproject.content_rule_grub2_uefi_admin_username
+++ xccdf_org.ssgproject.content_rule_grub2_uefi_admin_username
@@ -17,12 +17,15 @@
Change the superuser to a different username (The default is 'root').
$ sed -i 's/\(set superusers=\).*/\1"<unique user ID>"/g' /etc/grub.d/01_users
-
+The line mentioned above must be followed by the line
+export superusers
+so that the superusers is honored.
+
Once the superuser account has been added,
update the
grub.cfg file by running:
-grubby --update-kernel=ALL --env=/boot/grub2/grubenv
+grub-mkconfig -o /boot/grub2/grub.cfg
[warning]:
To prevent hard-coded admin usernames, automatic remediation of this control is not available. Remediation |
|
Code Climate has analyzed commit bbb38aa and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
May 16, 2025
Collaborator
jan-cerny
left a comment
There was a problem hiding this comment.
I have run test scenarios on RHEL 8 and RHEL 9 and they passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Rationale:
These fixes are based on findings in https://issues.redhat.com/browse/RHEL-58818
Review Hints: