Skip to content

audit_ospp_general_ppc64le: architecture cannot contain 32 bit rules #13433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mab879 merged 1 commit into from
May 6, 2025
Merged

audit_ospp_general_ppc64le: architecture cannot contain 32 bit rules #13433

Mab879 merged 1 commit into from
May 6, 2025

Conversation

@vojtapolasek
Copy link
Collaborator

@vojtapolasek vojtapolasek commented May 6, 2025

Description:

  • remove rules which contain b32

Rationale:

  • these rules cannot be loaded and they prevent all other rules from loading (audit-rules.service)

Review Hints:

  1. install RHEL 10 on ppc64le machine
  2. remediate ospp profile from datastream built before this PR is applied
  3. run augen-rules --load
  4. Now try the same with this PR applied

@vojtapolasek vojtapolasek added RHEL9 Red Hat Enterprise Linux 9 product related. Update Rule Issues or pull requests related to Rules updates. OSPP OSPP benchmark related. RHEL10 Red Hat Enterprise Linux 10 product related. labels May 6, 2025
@vojtapolasek vojtapolasek added this to the 0.1.77 milestone May 6, 2025
@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented May 6, 2025

Code Climate has analyzed commit 8c37cb9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 self-assigned this May 6, 2025
@Mab879
Copy link
Member

Mab879 commented May 6, 2025

I will note the sample rules on ppc64le are also wrong.

[root@ppc64le~]# grep b32 /usr/share/audit-rules/30-ospp-v42.rules | wc -l
31
[root@ppc64le~]# arch
ppc64le

@Mab879 Mab879 merged commit 9353ec7 into ComplianceAsCode:master May 6, 2025
108 of 110 checks passed
@vojtapolasek
Copy link
Collaborator Author

vojtapolasek commented May 7, 2025

I plan to make PR against upstream audit rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels

OSPP OSPP benchmark related. RHEL9 Red Hat Enterprise Linux 9 product related. RHEL10 Red Hat Enterprise Linux 10 product related. Update Rule Issues or pull requests related to Rules updates.

Projects

None yet

Milestone

0.1.77

Development

Successfully merging this pull request may close these issues.

2 participants

@vojtapolasek @Mab879