Clean Up CMake and build_product Product List #13280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust alphabetical ordering and formatting fixes.
90ec29c to
c227333
Compare
jan-cerny
reviewed
Apr 7, 2025
| message(STATUS "EKS: ${SSG_PRODUCT_EKS}") | ||
| message(STATUS "Fedora: ${SSG_PRODUCT_FEDORA}") | ||
| message(STATUS "Firefox: ${SSG_PRODUCT_FIREFOX}") | ||
| message(STATUS "MacOS 1015: ${SSG_PRODUCT_MACOS1015}") |
Collaborator
There was a problem hiding this comment.
Please sort this list as well. There is AL 2023 and OpenEmbedded at the end of the list.
|
Code Climate has analyzed commit e56c087 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Apr 8, 2025
Collaborator
jan-cerny
left a comment
There was a problem hiding this comment.
I have built RHEL 10 products.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Rationale:
Review Hints:
Maybe running
grep -ir macos .in the project root will help you confirm we got it all.Running
./build_product -d. You can skip the building all the content, just make sure it starts building content. If you run the command on master it will not start building.