Skip to content

Fix sshd oval check for SLE15, SLEM5 and opensuse #13197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
teacup-on-rockingchair merged 4 commits into from
Mar 27, 2025
Merged

Fix sshd oval check for SLE15, SLEM5 and opensuse #13197

teacup-on-rockingchair merged 4 commits into from
Mar 27, 2025

Conversation

@svet-se
Copy link
Contributor

@svet-se svet-se commented Mar 18, 2025

Description:

  • Fix sshd oval check for SLE15, SLEM5 and opensuse

Rationale:

  • It will be much better to check explicitly for the openssh-server pkg not implicitly

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Mar 18, 2025
@openshift-ci
Copy link

openshift-ci bot commented Mar 18, 2025

Hi @svet-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Mar 18, 2025

Code Climate has analyzed commit cf59820 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@vojtapolasek vojtapolasek self-assigned this Mar 25, 2025
@vojtapolasek
Copy link
Collaborator

vojtapolasek commented Mar 25, 2025

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Mar 25, 2025
@vojtapolasek
Copy link
Collaborator

vojtapolasek commented Mar 25, 2025

/packit retest-failed

1 similar comment
@vojtapolasek
Copy link
Collaborator

vojtapolasek commented Mar 26, 2025

/packit retest-failed

@teacup-on-rockingchair teacup-on-rockingchair added this to the 0.1.77 milestone Mar 27, 2025
@teacup-on-rockingchair teacup-on-rockingchair added OVAL OVAL update. Related to the systems assessments. SLES SUSE Linux Enterprise Server product related. labels Mar 27, 2025
teacup-on-rockingchair
teacup-on-rockingchair reviewed Mar 27, 2025
View reviewed changes
Copy link
Contributor

@teacup-on-rockingchair teacup-on-rockingchair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@teacup-on-rockingchair teacup-on-rockingchair merged commit d8bbbe8 into ComplianceAsCode:master Mar 27, 2025
110 of 112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teacup-on-rockingchair teacup-on-rockingchair teacup-on-rockingchair approved these changes

Assignees

@vojtapolasek vojtapolasek

Labels

ok-to-test Used by openshift-ci bot. OVAL OVAL update. Related to the systems assessments. SLES SUSE Linux Enterprise Server product related.

Projects

None yet

Milestone

0.1.77

Development

Successfully merging this pull request may close these issues.

3 participants

@svet-se @vojtapolasek @teacup-on-rockingchair