Skip to content

Add a default profile for Ubuntu2404 to add all rules to the datastream #13022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dodys merged 1 commit into from
Feb 12, 2025
Merged

Add a default profile for Ubuntu2404 to add all rules to the datastream #13022

dodys merged 1 commit into from
Feb 12, 2025

Conversation

@mpurg
Copy link
Contributor

@mpurg mpurg commented Feb 11, 2025

Description:

  • Add a default profile for Ubuntu 2404 to add all rules to the datastream

Rationale:

  • Fixes issue with unselected rules not being added to the datastream by default

@mpurg mpurg requested a review from a team as a code owner February 11, 2025 12:10
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Feb 11, 2025
@openshift-ci
Copy link

openshift-ci bot commented Feb 11, 2025

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mpurg mpurg force-pushed the ubuntu2404_default_profile branch from f12b650 to 187d153 Compare February 11, 2025 12:34
@dodys dodys self-assigned this Feb 11, 2025
@dodys dodys added Ubuntu Ubuntu product related. New Profile Issues or pull requests related to new Profiles. labels Feb 11, 2025
@dodys dodys added this to the 0.1.77 milestone Feb 11, 2025
@mpurg
Add a default profile for Ubuntu2404 to add all rules to the datastream
0bac91f 
By default, the unselected rules are not added to the datastream.
@mpurg mpurg force-pushed the ubuntu2404_default_profile branch from 187d153 to 0bac91f Compare February 12, 2025 08:32
@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Feb 12, 2025

Code Climate has analyzed commit 0bac91f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

dodys
dodys approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit c625acb into ComplianceAsCode:master Feb 12, 2025
134 of 135 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dodys dodys dodys approved these changes

Assignees

@dodys dodys

Labels

needs-ok-to-test Used by openshift-ci bot. New Profile Issues or pull requests related to new Profiles. Ubuntu Ubuntu product related.

Projects

None yet

Milestone

0.1.77

Development

Successfully merging this pull request may close these issues.

2 participants

@mpurg @dodys