Skip to content

Add new rule service_nginx_disabled #12629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mab879 merged 2 commits into from
Nov 22, 2024
Merged

Add new rule service_nginx_disabled #12629

Mab879 merged 2 commits into from
Nov 22, 2024

Conversation

@mpurg
Copy link
Contributor

@mpurg mpurg commented Nov 21, 2024

Description:

  • Add new rule service_nginx_disabled
  • Update ubuntu2404 CIS control 2.1.18
  • Replace hardcoded "httpd" package name with conditional in rule package_httpd_removed
  • Replace hardcoded "httpd" service name with conditional in rule service_httpd_disabled

@openshift-ci
Copy link

openshift-ci bot commented Nov 21, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Nov 21, 2024
@github-actions
Copy link

github-actions bot commented Nov 21, 2024

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Nov 21, 2024

Code Climate has analyzed commit 58ead97 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@Mab879
Copy link
Member

Mab879 commented Nov 22, 2024

/packit build

@Mab879 Mab879 self-assigned this Nov 22, 2024
@Mab879
Copy link
Member

Mab879 commented Nov 22, 2024

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Nov 22, 2024
@Mab879 Mab879 added this to the 0.1.76 milestone Nov 22, 2024
@Mab879
Copy link
Member

Mab879 commented Nov 22, 2024

Waving Automatus tests as they failing due to the rule not being the data stream.

@Mab879 Mab879 merged commit b477745 into ComplianceAsCode:master Nov 22, 2024
90 of 94 checks passed
@mpurg
Copy link
Contributor Author

mpurg commented Nov 22, 2024

@Mab879 please also a label for Ubuntu.

@Mab879 Mab879 added Ubuntu Ubuntu product related. New Rule Issues or pull requests related to new Rules. labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels

New Rule Issues or pull requests related to new Rules. ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related.

Projects

None yet

Milestone

0.1.76

Development

Successfully merging this pull request may close these issues.

2 participants

@mpurg @Mab879