Skip to content

Conversation

@mpurg
Copy link
Contributor

@mpurg mpurg commented Nov 21, 2024

Description:

  • Add new rule service_dnsmasq_disabled
  • Update control 2.1.5 in Ubuntu2404 CIS profile (Ensure dnsmasq services are not in use)

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Nov 21, 2024
@openshift-ci
Copy link

openshift-ci bot commented Nov 21, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

ubuntu2404 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions
Copy link

Change in Ansible shell module found.

Please consider using more suitable Ansible module than shell if possible.

@Mab879 Mab879 added Ubuntu Ubuntu product related. New Rule Issues or pull requests related to new Rules. labels Nov 22, 2024
@Mab879 Mab879 added this to the 0.1.76 milestone Nov 22, 2024
This fixes failing ctest 'components', with error:
`Rule 'service_dnsmasq_disabled' must be in component 'bind' because it's a member of 'dns' group.`
@mpurg mpurg requested a review from a team as a code owner November 25, 2024 07:51
@github-actions
Copy link

Change in Ansible shell module found.

Please consider using more suitable Ansible module than shell if possible.

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 5da830e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 7b52a14 into ComplianceAsCode:master Nov 25, 2024
89 of 94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Used by openshift-ci bot. New Rule Issues or pull requests related to new Rules. Ubuntu Ubuntu product related.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants