Skip to content

Remove not applicable rules for OL8 & OL9 #12558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mab879 merged 3 commits into from
Nov 8, 2024
Merged

Remove not applicable rules for OL8 & OL9 #12558

Mab879 merged 3 commits into from
Nov 8, 2024

Conversation

@Xeicker
Copy link
Contributor

@Xeicker Xeicker commented Oct 31, 2024

Description:

  • Delete default profiles in OL8 & OL9 as we found some non applicable rules in there so they are not reliable even for reference
  • Remove rules that depend on packages not available in OL8 & OL9 yum repos

Rationale:

  • This would allow to test rule ALL with automatus

@Xeicker
Remove not applicable rules for OL8
2f3aa3c 
Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@Xeicker
Remove not applicable rules for OL9
98204a5 
Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@Xeicker Xeicker added Oracle Linux Oracle Linux product related. Update Profile Issues or pull requests related to Profiles updates. labels Oct 31, 2024
@Xeicker Xeicker added this to the 0.1.75 milestone Oct 31, 2024
@Xeicker Xeicker requested a review from a team as a code owner October 31, 2024 22:21
@github-actions
Copy link

github-actions bot commented Oct 31, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879
Copy link
Member

Mab879 commented Nov 1, 2024

/packit build

@jan-cerny jan-cerny assigned jan-cerny and unassigned jan-cerny Nov 4, 2024
@Mab879
Copy link
Member

Mab879 commented Nov 4, 2024

The default profile is for keeping rules in the data stream, by removing it you risk breaking existing tailoring files. Just double checking to see if this is what you wanted.

@Mab879 Mab879 self-assigned this Nov 4, 2024
@Mab879 Mab879 modified the milestones: 0.1.75, 0.1.76 Nov 6, 2024
@Xeicker
Recover default profiles in OL8 & 9
57f2fdc 
Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@Xeicker
Copy link
Contributor Author

Xeicker commented Nov 7, 2024

I didn't consider that scenario, thanks for mentioning it. So better just removed rules that weren't applicable or are not ready for OL8 & 9

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Nov 7, 2024

Code Climate has analyzed commit 57f2fdc and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

Mab879
Mab879 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waving CI failures as they not related to this PR.

@Mab879
Copy link
Member

Mab879 commented Nov 8, 2024

Overriding CODEOWNERS since @Xeicker cannot approve his own PRs.

@Mab879 Mab879 merged commit 64926d6 into ComplianceAsCode:master Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels

Oracle Linux Oracle Linux product related. Update Profile Issues or pull requests related to Profiles updates.

Projects

None yet

Milestone

0.1.76

Development

Successfully merging this pull request may close these issues.

3 participants

@Xeicker @Mab879 @jan-cerny