Skip to content

RHEL 10 ISM_O: add back enable_fips_mode rule #12449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mab879 merged 1 commit into from
Oct 1, 2024
Merged

RHEL 10 ISM_O: add back enable_fips_mode rule #12449

Mab879 merged 1 commit into from
Oct 1, 2024

Conversation

@vojtapolasek
Copy link
Collaborator

@vojtapolasek vojtapolasek commented Oct 1, 2024

Description:

  • add back enable_fips_mode rule to all ISM_O profiles in RHEL 10

Rationale:

  • the rule was broken when the profile was being reviewed, but now it is working again.
  • Also, the cryptopolicy is configured to FIPS, so it is natural to have the enable_fips_mode rule there.

Review Hints:

  • build the product and check the profile content
  • use Automatus in profile mode

@vojtapolasek vojtapolasek added Update Profile Issues or pull requests related to Profiles updates. RHEL10 Red Hat Enterprise Linux 10 product related. labels Oct 1, 2024
@vojtapolasek vojtapolasek added this to the 0.1.75 milestone Oct 1, 2024
@vojtapolasek vojtapolasek requested a review from a team as a code owner October 1, 2024 09:06
@github-actions
Copy link

github-actions bot commented Oct 1, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions
Copy link

github-actions bot commented Oct 1, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12449
This image was built from commit: 4a69c49

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12449

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12449 make deploy-local

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Oct 1, 2024

Code Climate has analyzed commit 4a69c49 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.5% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 self-assigned this Oct 1, 2024
Mab879
Mab879 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mab879 Mab879 merged commit 00ac2b4 into ComplianceAsCode:master Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels

RHEL10 Red Hat Enterprise Linux 10 product related. Update Profile Issues or pull requests related to Profiles updates.

Projects

None yet

Milestone

0.1.75

Development

Successfully merging this pull request may close these issues.

2 participants

@vojtapolasek @Mab879