Skip to content

Fix platforms -> platform in test metadata #12057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dodys merged 1 commit into from
Jun 12, 2024
Merged

Fix platforms -> platform in test metadata #12057

dodys merged 1 commit into from
Jun 12, 2024

Conversation

@Mab879
Copy link
Member

@Mab879 Mab879 commented Jun 11, 2024

Description:

grep -lr '# platforms = ' linux_os | xargs sed -i "s/# platforms =/# platform =/"

The keyword platforms is not valid.

Rationale:

Make the tests work as expected.

@Mab879 Mab879 added the Test Suite Update in Test Suite. label Jun 11, 2024
@Mab879 Mab879 added this to the 0.1.74 milestone Jun 11, 2024
@github-actions
Copy link

github-actions bot commented Jun 11, 2024

Start a new ephemeral environment with changes proposed in this pull request:

rhel7 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879
Copy link
Member Author

Mab879 commented Jun 11, 2024

@dodys @mpurg just an FYI.

The reason why I caught this is testing after #12042 was merged.

I might try to add some CI to catch this.

@Mab879 Mab879 added the productization-issue Issue found in upstream stabilization process. label Jun 11, 2024
@github-actions
Copy link

github-actions bot commented Jun 11, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12057
This image was built from commit: dca2547

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12057

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12057 make deploy-local

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Jun 11, 2024

Code Climate has analyzed commit dca2547 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

jan-cerny
jan-cerny reviewed Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mab879 Can we have a check in the headers parser for invalid keywords? I assume that it could be difficult because of various comments but we could limit it to check the lines that contains an = sign.

@mpurg
Copy link
Contributor

mpurg commented Jun 12, 2024

Thanks for catching this. Sorry for the troubles.

@dodys
Copy link
Contributor

dodys commented Jun 12, 2024

perhaps this should be in the ctests?

@Mab879
Copy link
Member Author

Mab879 commented Jun 12, 2024

@Mab879 Can we have a check in the headers parser for invalid keywords? I assume that it could be difficult because of various comments but we could limit it to check the lines that contains an = sign.

I can, but that should in a separate PR.

dodys
dodys approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys self-assigned this Jun 12, 2024
@dodys dodys merged commit 0e6c15e into ComplianceAsCode:master Jun 12, 2024
@Mab879 Mab879 deleted the fix_platforms_in_tests branch June 12, 2024 13:13
@Mab879 Mab879 mentioned this pull request Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jan-cerny jan-cerny jan-cerny left review comments

@dodys dodys dodys approved these changes

Assignees

@dodys dodys

Labels

productization-issue Issue found in upstream stabilization process. Test Suite Update in Test Suite.

Projects

None yet

Milestone

0.1.74

Development

Successfully merging this pull request may close these issues.

4 participants

@Mab879 @mpurg @dodys @jan-cerny