Github Action Ansible shell module changes check
#12014
Conversation
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
4426867 to
7d477c5
Compare
7d477c5 to
112e46a
Compare
|
@matusmarhefka Updated (pushed the change also to my fork PR so it's shown in that GH CI check as well). |
linux_os/guide/system/accounts/enable_authselect/ansible/shared.yml
Outdated
Show resolved
Hide resolved
112e46a to
c91216e
Compare
c91216e to
78f77a5
Compare
|
Code Climate has analyzed commit 78f77a5 and detected 2 issues on this pull request. Here's the issue category breakdown:
Note: there is 1 critical issue. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
Description:
CI check to notify if a Ansible
shell/commandmodule usage has been changed.It's preferred to use specific Ansible module rather than abuse
shell(command) module. So we want to haveshell(command) module used only in approved corner cases when there is no other option.Review Hints:
SeeCompare DS / Generate Diff (pull_request)check and bot PR comments.There is extra commit to trigger the updated CI. The commit must be removed before merging.
It's seems as it's not possible to show it in CaC/content repo CI before merge. To show the check, I've created extra PR in my private repo - mildas#3 (see
Compare DS / Generate Diff (pull_request)check and bot PR comments)