Skip to content

Fix Ubuntu faillock #11932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dodys merged 1 commit into from
May 6, 2024
Merged

Fix Ubuntu faillock #11932

dodys merged 1 commit into from
May 6, 2024

Conversation

@alanmcanonical
Copy link
Contributor

@alanmcanonical alanmcanonical commented May 2, 2024 •
edited
Loading

Description:

Rationale:

  • Remove unused file /etc/pam.d/password-auth to avoid false failed check

@openshift-ci
Copy link

openshift-ci bot commented May 2, 2024

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label May 2, 2024
@github-actions
Copy link

github-actions bot commented May 2, 2024

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11932
This image was built from commit: 370d1cd

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11932

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11932 make deploy-local

@alanmcanonical alanmcanonical marked this pull request as draft May 2, 2024 13:37
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label May 2, 2024
@alanmcanonical
Fix pam files used in macro bash_pam_faillock_parameter_value
370d1cd 
Remove unusued file /etc/pam.d/password-auth
Fix tests
@alanmcanonical alanmcanonical marked this pull request as ready for review May 2, 2024 13:54
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label May 2, 2024
@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented May 2, 2024

Code Climate has analyzed commit 370d1cd and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@dodys dodys requested a review from a team May 6, 2024 08:45
@dodys dodys self-assigned this May 6, 2024
@dodys dodys added Ubuntu Ubuntu product related. ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels May 6, 2024
dodys
dodys approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit a5c8651 into ComplianceAsCode:master May 6, 2024
@Mab879 Mab879 added this to the 0.1.74 milestone May 6, 2024
@Mab879 Mab879 added the Bash Bash remediation update. label May 6, 2024
@alanmcanonical alanmcanonical deleted the fix_faillock branch May 30, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dodys dodys dodys approved these changes

Assignees

@dodys dodys

Labels

Bash Bash remediation update. ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related.

Projects

None yet

Milestone

0.1.74

Development

Successfully merging this pull request may close these issues.

3 participants

@alanmcanonical @dodys @Mab879