Skip to content

Update ol9 pcidss #11873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mab879 merged 6 commits into from
Apr 26, 2024
Merged

Update ol9 pcidss #11873

Mab879 merged 6 commits into from
Apr 26, 2024

Conversation

@Xeicker
Copy link
Contributor

@Xeicker Xeicker commented Apr 23, 2024

Description:

  • Update OL9 pci-dss profile
    • Add ansible to OL in rules(by setting the ol platform):
    • chronyd_run_as_chrony_user
    • network_nmcli_permissions
  • Add tests to OL in rule chronyd_run_as_chrony_user
  • Update applicability in rule timer_logrotate_enabled to only run in OL9
  • Create tests for network_nmcli_permissions

Rationale:

  • Sync OL9 pci-dss profile with latest

@Xeicker Xeicker requested a review from a team as a code owner April 23, 2024 18:59
@github-actions
Copy link

github-actions bot commented Apr 23, 2024

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11873
This image was built from commit: eaecf97

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11873

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11873 make deploy-local

@Xeicker Xeicker added Oracle Linux Oracle Linux product related. Update Profile Issues or pull requests related to Profiles updates. pci-dss labels Apr 24, 2024
@Mab879
Copy link
Member

Mab879 commented Apr 26, 2024

Please rebase this PR on latest master, that should help resolve the CI issues.

@Mab879 Mab879 added this to the 0.1.73 milestone Apr 26, 2024
@Mab879 Mab879 self-assigned this Apr 26, 2024
@Mab879 Mab879 removed this from the 0.1.73 milestone Apr 26, 2024
@Mab879
Copy link
Member

Mab879 commented Apr 26, 2024

Please rebase this PR on the latest master that should fix the issues with the tests.

Xeicker added 6 commits April 26, 2024 10:12
@Xeicker
Update ol9 pci-dss profile
fc7a0ce 
Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@Xeicker
Add ansible to ol in chronyd_run_as_chrony_user
3321851 
Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@Xeicker
Add tests to ol in chronyd_run_as_chrony_user
e53b330 
Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@Xeicker
Update platform for ol in timer_logrotate_enabled
455eb0d 
Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@Xeicker
Add ansible to ol9 in network_nmcli_permissions
be79cee 
Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@Xeicker
Add tests to network_nmcli_permissions
eaecf97 
Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@Xeicker Xeicker force-pushed the update_ol9_pcidss branch from 38d7ff0 to eaecf97 Compare April 26, 2024 16:13
@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Apr 26, 2024

Code Climate has analyzed commit eaecf97 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

Mab879
Mab879 approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Overriding CODEOWNERS as @Xeicker cannot approve his own PRs.

@Mab879 Mab879 merged commit 59013f6 into ComplianceAsCode:master Apr 26, 2024
@Mab879 Mab879 added this to the 0.1.73 milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels

Oracle Linux Oracle Linux product related. pci-dss Update Profile Issues or pull requests related to Profiles updates.

Projects

None yet

Milestone

0.1.73

Development

Successfully merging this pull request may close these issues.

2 participants

@Xeicker @Mab879