Skip to content

update meaning of the "automated" status in control files #11646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcusburghardt merged 3 commits into from
Mar 6, 2024
Merged

update meaning of the "automated" status in control files #11646

marcusburghardt merged 3 commits into from
Mar 6, 2024

Conversation

@vojtapolasek
Copy link
Collaborator

@vojtapolasek vojtapolasek commented Mar 4, 2024

Description:

  • extend the definition of that status
  • update two related cases in ANSSI control file

Rationale:

  • sometimes a requirement can be reasonably automated only partially... but that does not mean it should have the "partial" status. The "partial" status suggests that something can be automated but it is not implemented yet.

@vojtapolasek
update description of the "automated" status for control files
5ddbc99
@vojtapolasek
update R36 in ANSSI
8fa7195 
WRT to the update of the definition of the "automated" status, this requirement can be marked as automated.
@vojtapolasek
change status of ANSSI R29 to automated
d8c502e 
WTR to previous changes in definition of the "automated" status, I think this change is legit.
@vojtapolasek vojtapolasek added Documentation Update in project documentation. ANSSI ANSSI Benchmark related. labels Mar 4, 2024
@vojtapolasek vojtapolasek added this to the 0.1.73 milestone Mar 4, 2024
@github-actions
Copy link

github-actions bot commented Mar 4, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions
Copy link

github-actions bot commented Mar 4, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11646

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11646

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11646 make deploy-local

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Mar 4, 2024

Code Climate has analyzed commit d8c502e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.8% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt self-assigned this Mar 6, 2024
marcusburghardt
marcusburghardt approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcusburghardt marcusburghardt merged commit 367afe5 into ComplianceAsCode:master Mar 6, 2024
@marcusburghardt
Copy link
Member

marcusburghardt commented Mar 13, 2024

For register, it was discussed in #11639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcusburghardt marcusburghardt marcusburghardt approved these changes

Assignees

@marcusburghardt marcusburghardt

Labels

ANSSI ANSSI Benchmark related. Documentation Update in project documentation.

Projects

None yet

Milestone

0.1.73

Development

Successfully merging this pull request may close these issues.

2 participants

@vojtapolasek @marcusburghardt